Repository navigation
fix(deploy): preserve maintenance owner context - #885
Merged
Merged
Conversation
|
You have reached your Codex usage limits for security reviews. Please try again later. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更说明 / Summary
schema claim 的单次 RPC 结束后会取消请求 context,原先 retained physical fence 也把该请求 context 当作 owner 生命周期,导致后续 worker/status 立即拒绝。现在 schema controller 持有独立 owner context,保留到 controller 生命周期结束;建立连接和获取锁仍使用原来单次操作的预算。
普通部署入口保持原有 context 行为。四个文件直接基于正式 Go116 源码,只调整 internal/deploycli 的 schema fence 生命周期并新增回归测试;API 运行源码、Web、依赖、协议和打包输入与正式116一致。
与上游的关系 / Upstream relationship
上游参考 / Upstream reference: N/A(本项目原生部署控制器)
关联 Issue / Related issue
N/A;修复 schema claim 后 retained fence 错误继承单次 RPC context 的生命周期。
变更类型 / Type of change
验证 / Verification
测试源码:
3adaf17b2444a73f435bef4865381d2538670179,签名、干净工作树;父提交为正式116源码d8a90269ee2cd29d926ac1b3caa02f68725237ef。原始通过日志已通过正式
scripts/local-release-tests.py import导入,并逐项 verify 到同一源码;未重跑或重标其他源码的测试。测试模拟 RPC request 生命周期并使用真实隔离 PostgreSQL;未声明完整 Unix RPC/systemd claim 或生产 PG17 验收。应用源码与正式116对象一致,复用既有应用验证;未重复完整 API/Web 矩阵或本地应用构建。本 PR 尚未部署。截图或日志 / Screenshots or logs
保留原始 verification、Go JSON stdout 和入口 stderr。原始 verification SHA256:
a1a7ccd5ab9ac54087a32c576a91949f1aa4186b7e3799712cd72b92ba56021d;正式 Go 记录:e639baad6403b454d9dae377d6377e989e6755344d51af9d9b7471a41ef4b575;入口记录:bf0dd6e6630f41af3cc48d33a99ade7e66a3ac151350aceee0ed20a6bf654898。提交检查 / Checklist